feat(clerk-js): Support different CAPTCHA widget types - #3154
Merged
anagstef merged 5 commits intoApr 11, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: 59fe612 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nikosdouvlis
marked this pull request as draft
April 10, 2024 08:48
anagstef
force-pushed
the
stefanos/core-1988-poc-with-interactive-turnstile-widget-on-sign-up-component
branch
from
April 10, 2024 11:57
6ac98e8 to
d187452
Compare
anagstef
marked this pull request as ready for review
April 10, 2024 12:09
dimkl
approved these changes
Apr 10, 2024
Member
|
@anagstef can this be styled by consumers? If yes, how will we support that? |
anagstef
force-pushed
the
stefanos/core-1988-poc-with-interactive-turnstile-widget-on-sign-up-component
branch
from
April 10, 2024 15:18
f199302 to
b87c910
Compare
Contributor
Author
|
@brkalow it can receive a theme between |
anagstef
enabled auto-merge (squash)
April 11, 2024 10:09
…stile-widget-on-sign-up-component
anagstef
deleted the
stefanos/core-1988-poc-with-interactive-turnstile-widget-on-sign-up-component
branch
April 11, 2024 10:28
Merged
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for different CAPTCHA widgets coming from the FAPI.
Current behavior:
Currently, we support only an invisible captcha widget. This widget gets rendered in an injected div element at the end of the document body.
After this PR:
For backward compatibility, we will support the previous functionality when the user has selected the
"invisible"widget. This is the setting to which all current users will be migrated.This PR adds support for a visible challenge if needed on sign-up. This challenge gets rendered on the
<div id="clerk-captcha" />element in the SignUp form.Users with custom sign-up flows must have the
<div id="clerk-captcha" />element inside their DOM when calling thesignUp.createfunction.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change